fix(rust): protect recent uncommitted files in vacuum full mode #3835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
vsmanish1772
changed the title
This change prevents race conditions where concurrent writer's uncommitted files could be deleted before the transaction is committed. Now files that are not referenced in the log but are younger than the retention period will be protected from deletion during vacuum operations in Full mode. Added test to verify the behavior of protecting recent uncommitted files. Signed-off-by: Manish Sogiyawar <[email protected]>
vsmanish1772
force-pushed
the
fix-vacuum-race-condition
branch
from
f7305f0 to
838d189
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3835 +/- ##
==========================================
+ Coverage 74.33% 74.35% +0.01%
==========================================
Files 147 147
Lines 39607 39648 +41
Branches 39607 39648 +41
==========================================
+ Hits 29442 29479 +37
- Misses 8775 8779 +4
Partials 1390 1390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtyler
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protects recently written uncommitted files from deletion during vacuum operations in Full mode to prevent race conditions.
Changes
test_vacuum_full_protects_recent_uncommitted_filesRelated Issue(s)
Prevents race condition where concurrent writer's uncommitted files could be deleted before transaction commit, avoiding potential data loss.
Documentation
Added inline comments explaining the race condition protection logic.